Code style / syntax cleanup #2 #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 3, 2013 13:50
…om_checkin & com_config
ghost
mentioned this pull request
There was a problem hiding this comment.
I think these two lines are OK using inline conditionals. Our layout files have selective enforcement of many of the PHPCS rules due to the mixed HTML/PHP nature which causes a lot of false failures otherwise.
There was a problem hiding this comment.
Changed inline if syntax from:
if ($listDirn == 'asc') echo 'selected="selected"';
to:
echo $listDirn == 'asc' ? ' selected="selected"' : '';
ghost
deleted the
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31323
These are code style and minor syntax changes. So nothing in functionality should be changed.
This PR is the 2nd in a series.
This is a cleanup of the following folders:
/administrator/components/com_categories
/administrator/components/com_checkin
/administrator/components/com_config
administrator/templates/hathor/html/com_categories
administrator/templates/hathor/html/com_checkin
/administrator/templates/hathor/html/com_config
Testing instructions
Check if all the views of these components still function as expected.
PR Series